Module:Message box: Difference between revisions

From NvWiki
Jump to navigation Jump to search
below in div mbox
 
Line 1: Line 1:
require('strict')
{{oldtfdfull|date= 2020 February 15 |result=keep |disc=Module:Message box}}
local getArgs
<noinclude>{{permprot}}</noinclude>
local yesno = require('Module:Yesno')
{{Archives|bot=lowercase sigmabot III|age=30}}
local lang = mw.language.getContentLanguage()
{{User:MiszaBot/config
| algo                = old(30d)
| archive            = Module talk:Message box/Archive %(counter)d
| counter            = 2
| maxarchivesize      = 150K
| archiveheader      = {{Automatic archive navigator}}
| minthreadstoarchive = 1
| minthreadsleft      = 4
}}


local CONFIG_MODULE = 'Module:Message box/configuration'
==CSS instead of tables==
local DEMOSPACES = {talk = 'tmbox', image = 'imbox', file = 'imbox', category = 'cmbox', article = 'ambox', main = 'ambox'}
<!-- [[User:DoNotArchiveUntil]] 07:19, 19 November 2026 (UTC) -->{{User:ClueBot III/DoNotArchiveUntil|1795072785}}
{{moved discussion from|Template talk:Ambox#CSS instead of tables|[[User:Sapphaline|Sapphaline]] ([[User talk:Sapphaline|talk]]) 10:25, 20 August 2025 (UTC)}}
Could this thing use <code><nowiki><div style="display:table;"></nowiki></code> and <code><nowiki><div style="display:table-cell;"></nowiki></code> instead of literal tables and table cells (<code><nowiki><table></nowiki></code>, <code><nowiki><td></nowiki></code>)?


--------------------------------------------------------------------------------
Were the any previous attempts to remake this using <code><nowiki><div></nowiki></code>? If so, what was the consensus? [[User:Sapphaline|Sapphaline]] ([[User talk:Sapphaline|talk]]) 09:46, 20 August 2025 (UTC)
-- Helper functions
--------------------------------------------------------------------------------


local function getTitleObject(...)
:A long time ago this would have been converted to divs but apparently IE sucked (this should not be news).
-- Get the title object, passing the function through pcall
:Today, I have [[User:Izno/Sandbox/Ambox]] with what are some skimmings and started a sandbox at [[Module:Message box/div]]. I have just done a very bad job of finishing this work. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:09, 24 August 2025 (UTC)
-- in case we are over the expensive function count limit.
::Which might be closer to done than not, honestly. I think what it currently needs is to
local success, title = pcall(mw.title.new, ...)
::# Double check the ambox work
if success then
::# Add "soft" support for the other kinds of boxes (where soft is defined as module-supports but config disabled)
return title
::# Merge tested /div version but not CSS into main
end
::# Enable boxes of each kind one by one.
end
::#* Leave ambox for penultimate as the most likely to cause some mass noise in a way
::#* Probably somewhere around here do ombox, [https://en.wikipedia.org/w/index.php?search=insource%3A%2FMessage%5B%20_%5Dbox%5C%2Fombox%5C.css%2F%20-intitle%3A%2F(%5BSs%5Dandbox%7C%5C%2Fdoc)%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns10=1&ns828=1 that has some needed coordination]
::#* Leave tmbox for ultimate, there is work to [https://en.wikipedia.org/w/index.php?search=insource%3A%2FMessage%5B%20_%5Dbox%5C%2Ftmbox%5C.css%2F%20-intitle%3A%2F(%5BSs%5Dandbox%7C%5C%2Fdoc)%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns10=1&ns828=1 coordinate]
::# Fix bugs that are identified
::# Move CSS over to better-named stylesheet
::# Delete the /div CSS (I won't be too sad)
::# Remove main support for table versions, possibly rename some things
::[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:42, 24 August 2025 (UTC)
::I have now put this plan in a publicly editable place at [[Module:Message box/div/doc]]. [[User:Izno|Izno]][[User:IznoPublic|Public]] ([[User talk:Izno#top|talk]]) 00:26, 26 August 2025 (UTC)
::Hi! I didn't know you were doing this, so I made something similar. It seems to work:
::* Module: [https://en.wikipedia.org/w/index.php?title=Module%3AMessage_box%2Fsandbox&diff=1310791170&oldid=1300331049]
::* Styles: [https://en.wikipedia.org/w/index.php?title=Module%3AMessage_box%2Fsandbox%2Fambox.css&diff=1310791252&oldid=1305438959]
:: [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 16:57, 11 September 2025 (UTC)
:::Yes, I did it in its own sandbox because it's a longterm enough project not to be done in the main sandbox, which should generally be releasable ad hoc for trivial issues. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:03, 11 September 2025 (UTC)
:::And also, there are enough other dependencies that "just change the two or three places" isn't going to fly. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:06, 11 September 2025 (UTC)
::::Where else do you think this will affect? ​​It seems that only the mobile version is oriented towards <syntaxhighlight inline lang="css">table.ambox</syntaxhighlight>, which can also be corrected by CSS [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 17:09, 11 September 2025 (UTC)
:::::I have already documented in [[Module:Message box/div/doc]] multiple places that will need careful work, ambox among them. Please feel free to peruse and ask questions about what's there and why. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:41, 11 September 2025 (UTC)
::::::Thanks! [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 17:47, 11 September 2025 (UTC)
:What's broken here? I've probably wrong but AFAIK for accessibility the existing role="presentation" should suffice. [[User:Aaron Liu|<span class="skin-invert" style="color:#0645ad">Aaron Liu</span>]] ([[User talk:Aaron Liu#top|talk]]) 23:21, 28 August 2025 (UTC)
::You should always endeavor to use the default aria role element. In this case, that's not a table. Ignoring that, tables are shit for doing other presentation with. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:20, 29 August 2025 (UTC)
:::This /div work is great work, thanks for this <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 19:49, 8 September 2025 (UTC)
:Ok, I think we can do {{tl|cmbox}} now. Based on what I wrote down before, the process of a rollout is:
:# Alert some key pages. Has to include some verbiage like <blockquote>A change is occurring to how {{tl|cmbox}} is implemented to support mobile resolutions better. It may cause some temporary display weirdness. Further information is available at [[Module talk:Message box#cmbox migration]].</blockquote> with some text at the specific section <blockquote><p>A change is planned to occur in how {{tl|cmbox}} is implemented. It should help improve display at mobile resolutions now, and accessibility later. cmbox was chosen because it has lower reader-facing impact than most other message box types and it's fairly self-contained. The change to cmbox will likely pave the way for other message boxes ({{tl|fmbox}} is probably next).</p><p>You can expect some difference in styling from previous for a small period due to the [[WP:Job queue|job queue]], after which it should return to "normal". You should be able to correct it manually if you want with one of the usual steps ([[WP:PURGE|purge]], [[WP:NULL|null edit]], or [[Help:Dummy edit|dummy edit]]). If an issue with display persists, leave a comment here (this scenario may be possible with some unexpected setup cmboxes).</p></blockquote>
:#* Here (here, here is the warning)
:#* [[WP:VPT]]
:#* [[MediaWiki talk:Common.css]]
:#* Maybe [[WT:CAT]] and [[WT:CFD]]
:# Sync [[Module:Message box/sandbox]] to [[Module:Message box]] (first time only)
:# Within quick succession to next step, sync [[Module:Message box/configuration/sandbox]] to [[Module:Message box/configuration]]
:# Within quick succession to previous step, sync [[Module:Message box/div/cmbox.css]] to [[Module:Message box/cmbox.css]]
:[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:08, 1 October 2025 (UTC)
:: The /div main and config modules have got some other adjustments that now make it different from what will end up going live, so they shouldn't generally be synced directly. For future me. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:59, 1 October 2025 (UTC)
::Also messages now posted to VPT and Common.css. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:00, 1 October 2025 (UTC)
::cmbox is deployed. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:30, 2 October 2025 (UTC)
:::Ok, cmbox has been basically quiet besides notes from the below. I will now work on fmbox, which should also be relatively low impact. I'm also starting to sketch out imbox which may need to interact with template content from Commons as well as [[:c:MediaWiki:Filepage.css]]. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:44, 7 October 2025 (UTC)
::::Turns out I don't currently have to worry about commons names, which is something I should have noted when I split message box CSS during the TemplateStylization. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 01:03, 17 October 2025 (UTC)
:::::What does {{tq|split message box CSS during the TemplateStylization}} mean exactly?
:::::Also, what can I help with. <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 03:56, 17 October 2025 (UTC)
::::::All of the CSS for the message boxes was once in [[MediaWiki:Common.css]]. I moved it to TemplateStyles with some effort because of [[MediaWiki talk:Common.css/to do#description|reasons]].
::::::This effort now that I've got my feet under me probably doesn't need much assistance. If you want to spend time on something, working on the problems listed at [[MediaWiki talk:Common.css/to do#Infobox]] would be excellent. If you want to spend some time on stuff, crafting an infobox (using Lua or template) to fix our ''career statistics'' pages would be super helpful. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 00:27, 19 October 2025 (UTC)
:{{ping|Izno}} any progress?  [[user:sapphaline|<span class="skin-nightmode-reset-color" style="color:#c20;text-decoration:underline">sapphaline</span>]] ([[user talk:sapphaline|<span class="skin-nightmode-reset-color" style="color:#236;text-decoration:underline">talk</span>]]) 13:20, 18 December 2025 (UTC)
::You can see the progress at [[Module:Message box/div/doc]]. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 18:08, 18 December 2025 (UTC)


local function union(t1, t2)
== imbox migration ==
-- Returns the union of two arrays.
local vals = {}
for i, v in ipairs(t1) do
vals[v] = true
end
for i, v in ipairs(t2) do
vals[v] = true
end
local ret = {}
for k in pairs(vals) do
table.insert(ret, k)
end
table.sort(ret)
return ret
end


local function getArgNums(args, prefix)
A change is occurring in how {{tl|imbox}} is implemented. It should help improve display at mobile resolutions now, and accessibility later. imbox was chosen third because it has lower reader-facing impact than most other message box types and it's fairly self-contained. (There is some other planning information in [[#CSS instead of tables]].) (Previously, [[#cmbox migration|cmbox]] and [[#fmbox migration|fmbox]] were done.)
local nums = {}
for k, v in pairs(args) do
local num = mw.ustring.match(tostring(k), '^' .. prefix .. '([1-9]%d*)$')
if num then
table.insert(nums, tonumber(num))
end
end
table.sort(nums)
return nums
end


--------------------------------------------------------------------------------
You can expect some difference in styling from previous for a small period due to the [[WP:Job queue|job queue]], after which it should return to "normal". You should be able to correct it manually if you want with one of the usual steps ([[WP:PURGE|purge]], [[WP:NULL|null edit]], or [[Help:Dummy edit|dummy edit]]). If an issue with display persists, leave a comment here (this scenario may be possible with some unexpected setup imboxes). This may also, but should not have, affected the already-migrated cmbox and fmbox, so if those also appear to have an issue, here is a good spot now. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 18:34, 19 October 2025 (UTC)
-- Box class definition
--------------------------------------------------------------------------------


local MessageBox = {}
== T367463 ==
MessageBox.__index = MessageBox


function MessageBox.new(boxType, args, cfg)
Since it's fixed, can the relevant CSS rule be removed? [[User:Andyrom75|<span style="color:#BB0000; font-family:Papyrus; font-size:12px">'''Andyrom75'''</span>]] ([[User talk:Andyrom75|talk]]) 07:07, 19 November 2025 (UTC)
args = args or {}
local obj = {}


-- Set the title object and the namespace.
:@[[User:Izno|Izno]], @[[User:Jdlrobson|Jdlrobson]], ping. [[User:Andyrom75|<span style="color:#BB0000; font-family:Papyrus; font-size:12px">'''Andyrom75'''</span>]] ([[User talk:Andyrom75|talk]]) 07:08, 19 November 2025 (UTC)
obj.title = getTitleObject(args.page) or mw.title.getCurrentTitle()
::What do you think is fixed exactly? [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 07:14, 19 November 2025 (UTC)
::And what rule do you think should be removed? [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 07:19, 19 November 2025 (UTC)


-- Set the config for our box type.
==Plural for {{Tlx|Hooks}}==
obj.cfg = cfg[boxType]
if not obj.cfg then
local ns = obj.title.namespace
-- boxType is "mbox" or invalid input
if args.demospace and args.demospace ~= '' then
-- implement demospace parameter of mbox
local demospace = string.lower(args.demospace)
if DEMOSPACES[demospace] then
-- use template from DEMOSPACES
obj.cfg = cfg[DEMOSPACES[demospace]]
elseif string.find( demospace, 'talk' ) then
-- demo as a talk page
obj.cfg = cfg.tmbox
else
-- default to ombox
obj.cfg = cfg.ombox
end
elseif ns == 0 then
obj.cfg = cfg.ambox -- main namespace
elseif ns == 6 then
obj.cfg = cfg.imbox -- file namespace
elseif ns == 14 then
obj.cfg = cfg.cmbox -- category namespace
else
local nsTable = mw.site.namespaces[ns]
if nsTable and nsTable.isTalk then
obj.cfg = cfg.tmbox -- any talk namespace
else
obj.cfg = cfg.ombox -- other namespaces or invalid input
end
end
end


-- Set the arguments, and remove all blank arguments except for the ones
{{edit fully-protected|answered=yes}}
-- listed in cfg.allowBlankParams.
do
local newArgs = {}
for k, v in pairs(args) do
if v ~= '' then
newArgs[k] = v
end
end
for i, param in ipairs(obj.cfg.allowBlankParams or {}) do
newArgs[param] = args[param]
end
obj.args = newArgs
end


-- Define internal data structure.
obj.categories = {}
obj.classes = {}
-- For lazy loading of [[Module:Category handler]].
obj.hasCategories = false


return setmetatable(obj, MessageBox)
Please copy [https://en.wikipedia.org/w/index.php?title=Module:Message_box/sandbox&oldid=1327882000 this sandbox version] (not the current version, which links to Module:Message box/configuration/sandbox) to live.
end


function MessageBox:addCat(ns, cat, sort)
[https://en.wikipedia.org/w/index.php?title=Module%3AMessage_box%2Fsandbox&diff=1327882000&oldid=1317219285 Changes.]
if not cat then
return nil
end
if sort then
cat = string.format('[[Category:%s|%s]]', cat, sort)
else
cat = string.format('[[Category:%s]]', cat)
end
self.hasCategories = true
self.categories[ns] = self.categories[ns] or {}
table.insert(self.categories[ns], cat)
end


function MessageBox:addClass(class)
Let me know when done, and I'll update the documentation for the module, and make other tweaks.
if not class then
return nil
end
table.insert(self.classes, class)
end


function MessageBox:setParameters()
All the best: ''[[User:Rich Farmbrough|Rich]] [[User talk:Rich Farmbrough|Farmbrough]]''<small> 17:12, 16 December 2025 (UTC).<br /></small>
local args = self.args
:[[File:X mark.svg|20px|link=|alt=]] '''Not done for now:''' please establish a [[Wikipedia:Consensus|consensus]] for this alteration '''[[Wikipedia:Edit requests#Planning a request|before]]''' creating an edit request.<!-- Template:EP --> Namely, making a change to a template used on 20 million pages because you created a template today? For a wording tweak? Please show a consensus that this is something desirable. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 18:09, 16 December 2025 (UTC)
local cfg = self.cfg
:: Looking at the archive I see you make changes without awaiting consensus. I find this modern gatekeeping behaviour unfortunate. All the best: ''[[User:Rich Farmbrough|Rich]] [[User talk:Rich Farmbrough|Farmbrough]]''<small> 02:48, 17 December 2025 (UTC).<br /></small>
 
:::Flinging some incorrect mud (I have been very public about the changes I've implemented of my own resort in this module even if you didn't find where) is not any more likely to convince me or anyone else of the value of {{em|this}} change (see also [[WP:OTHERSTUFF]]: your edit request is relevant, not any of my edits).
-- Get type data.
:::I also note that you were apparently able to [https://en.wikipedia.org/w/index.php?title=Template:Hooks&diff=cur&oldid=1327880498 implement the same display as what you wanted] without making the change in this module. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 04:00, 17 December 2025 (UTC)
self.type = args.type
::::And just to be very clear, the two changes at my desire have been the following:
local typeData = cfg.types[self.type]
::::# Supporting TemplateStyles. In this module, that had prior requests at [[Module_talk:Message_box/Archive_1#Use_TemplateStyles|Use TemplateStyles]], [[Module_talk:Message_box/Archive_1#A_question_to_small_param_and_TemplateStyle|A question to small param and TemplateStyle]], and [[Module_talk:Message_box/Archive_1#Site-local_configuration_source_for_sisters_importing_from_here|Site-local configuration...]]. I had set up [[MediaWiki talk:Common.css/to do]] previously with provided description there, and have generally advertised that link every chance I get because I don't like being the only person spending time on making changes more accessible to a wider public (you may check [[Special:Whatlinkshere/MediaWiki talk:Common.css/to do|what links here]] at your leisure), and had also generally mused about the problem {{em|much}} earlier at [[Wikipedia_talk:TemplateStyles/Archive_1#In_the_context_of_meta_templates|In the context of meta templates]]. That culminated, when I finally got around to it, in [[Module_talk:Message_box/Archive_1#mbox_is_now_TemplateStyled_only|mbox is now TemplateStyled only]] and associated target link. For which there have been no complaints not trivially remedied.
self.invalidTypeError = cfg.showInvalidTypeError
::::# Changing the table structure to divs. {{em|That}} change is [[Module_talk:Message_box#CSS_instead_of_tables|right there]] and was also implicated in [[Module_talk:Message_box/Archive_1#Aria_roles|Aria roles]] and separately reinforced in the individual advertisements I've so far made, like [[Module_talk:Message_box/Archive_2#cmbox_migration|cmbox migration]]. The cmbox migration section was incidentally also advertised to VPT.
and self.type
::::Any other changes that I made were implemented due to requested edit. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 04:21, 17 December 2025 (UTC)
and not typeData
:::::I don't mind that you made intelligent changes to the module, saying "Ok I did it anyway" - in fact I absolutely support them. ''Even if I would have disagreed with them.''
typeData = typeData or cfg.types[cfg.default]
:::::And yes, I coded around the obstacle by using an older method which I had previously used in {{Tlx|Hook}} (which I created). People have "updated" that, I do them the courtesy of assuming that their updates add value, unless I know otherwise.
self.typeClass = typeData.class
:::::If someone wants to update {{Tlx|Hooks}} in the same way that {{Tlx|Hook}} was updated, they will have to, apparently, gain consensus. I won't.
self.typeImage = typeData.image
:::::If I see a problem on Wikipedia I like to fix it. If something stops me doing it one way, I'll usually try another.
self.typeImageNeedsLink = typeData.imageNeedsLink
:::::Hope that is all clear, and that you agree with my sentiments.
 
:::::All the best: ''[[User:Rich Farmbrough|Rich]] [[User talk:Rich Farmbrough|Farmbrough]]''<small> 13:47, 17 December 2025 (UTC).<br /></small>
-- Find if the box has been wrongly substituted.
self.isSubstituted = cfg.substCheck and args.subst == 'SUBST'
 
-- Find whether we are using a small message box.
self.isSmall = cfg.allowSmall and (
cfg.smallParam and args.small == cfg.smallParam
or not cfg.smallParam and yesno(args.small)
)
 
-- Set the below row.
self.below = cfg.below and args.below
-- Add attributes, classes and styles.
self.id = args.id
self.name = args.name
if self.name then
self:addClass('box-' .. string.gsub(self.name,' ','_'))
end
if yesno(args.plainlinks) ~= false then
self:addClass('plainlinks')
end
if self.below then
self:addClass('mbox-with-below')
end
for _, class in ipairs(cfg.classes or {}) do
self:addClass(class)
end
if self.isSmall then
self:addClass(cfg.smallClass or 'mbox-small')
end
self:addClass(self.typeClass)
self:addClass(args.class)
self.style = args.style
self.attrs = args.attrs
 
-- Set text style.
self.textstyle = args.textstyle
 
-- Set image classes.
self.imageRightClass = args.imagerightclass or args.imageclass
self.imageLeftClass = args.imageleftclass or args.imageclass
 
-- Find if we are on the template page or not. This functionality is only
-- used if useCollapsibleTextFields is set, or if both cfg.templateCategory
-- and cfg.templateCategoryRequireName are set.
self.useCollapsibleTextFields = cfg.useCollapsibleTextFields
if self.useCollapsibleTextFields
or cfg.templateCategory
and cfg.templateCategoryRequireName
then
if self.name then
local templateName = mw.ustring.match(
self.name,
'^[tT][eE][mM][pP][lL][aA][tT][eE][%s_]*:[%s_]*(.*)$'
) or self.name
templateName = 'Template:' .. templateName
self.templateTitle = getTitleObject(templateName)
end
self.isTemplatePage = self.templateTitle
and mw.title.equals(self.title, self.templateTitle)
end
-- Process data for collapsible text fields. At the moment these are only
-- used in {{ambox}}.
if self.useCollapsibleTextFields then
-- Get the self.issue value.
if self.isSmall and args.smalltext then
self.issue = args.smalltext
else
local sect
if args.sect == '' then
sect = 'This ' .. (cfg.sectionDefault or 'page')
elseif type(args.sect) == 'string' then
sect = 'This ' .. args.sect
end
local issue = args.issue
issue = type(issue) == 'string' and issue ~= '' and issue or nil
local text = args.text
text = type(text) == 'string' and text or nil
local issues = {}
table.insert(issues, sect)
table.insert(issues, issue)
table.insert(issues, text)
self.issue = table.concat(issues, ' ')
end
 
-- Get the self.talk value.
local talk = args.talk
-- Show talk links on the template page or template subpages if the talk
-- parameter is blank.
if talk == ''
and self.templateTitle
and (
mw.title.equals(self.templateTitle, self.title)
or self.title:isSubpageOf(self.templateTitle)
)
then
talk = '#'
elseif talk == '' then
talk = nil
end
if talk then
-- If the talk value is a talk page, make a link to that page. Else
-- assume that it's a section heading, and make a link to the talk
-- page of the current page with that section heading.
local talkTitle = getTitleObject(talk)
local talkArgIsTalkPage = true
if not talkTitle or not talkTitle.isTalkPage then
talkArgIsTalkPage = false
talkTitle = getTitleObject(
self.title.text,
mw.site.namespaces[self.title.namespace].talk.id
)
end
if talkTitle and talkTitle.exists then
                local talkText
                if self.isSmall then
                    local talkLink = talkArgIsTalkPage and talk or (talkTitle.prefixedText .. (talk == '#' and '' or '#') .. talk)
                    talkText = string.format('([[%s|talk]])', talkLink)
                else
                    talkText = 'Relevant discussion may be found on'
                    if talkArgIsTalkPage then
                        talkText = string.format(
                            '%s [[%s|%s]].',
                            talkText,
                            talk,
                            talkTitle.prefixedText
                        )
                    else
                        talkText = string.format(
                            '%s the [[%s' .. (talk == '#' and '' or '#') .. '%s|talk page]].',
                            talkText,
                            talkTitle.prefixedText,
                            talk
                        )
                    end
                end
self.talk = talkText
end
end
 
-- Get other values.
self.fix = args.fix ~= '' and args.fix or nil
local date
if args.date and args.date ~= '' then
date = args.date
elseif args.date == '' and self.isTemplatePage then
date = lang:formatDate('F Y')
end
if date then
self.date = string.format(" <span class='date-container'><i>(<span class='date'>%s</span>)</i></span>", date)
end
self.info = args.info
if yesno(args.removalnotice) then
self.removalNotice = cfg.removalNotice
end
end
 
-- Set the non-collapsible text field. At the moment this is used by all box
-- types other than ambox, and also by ambox when small=yes.
if self.isSmall then
self.text = args.smalltext or args.text
else
self.text = args.text
end
 
-- General image settings.
self.imageCellDiv = not self.isSmall and cfg.imageCellDiv
self.imageEmptyCell = cfg.imageEmptyCell
 
-- Left image settings.
local imageLeft = self.isSmall and args.smallimage or args.image
if cfg.imageCheckBlank and imageLeft ~= 'blank' and imageLeft ~= 'none'
or not cfg.imageCheckBlank and imageLeft ~= 'none'
then
self.imageLeft = imageLeft
if not imageLeft then
local imageSize = self.isSmall
and (cfg.imageSmallSize or '30x30px')
or '40x40px'
self.imageLeft = string.format('[[File:%s|%s%s|alt=]]', self.typeImage
or 'Information icon4.svg', imageSize, self.typeImageNeedsLink and "" or "|link=" )
end
end
 
-- Right image settings.
local imageRight = self.isSmall and args.smallimageright or args.imageright
if not (cfg.imageRightNone and imageRight == 'none') then
self.imageRight = imageRight
end
-- set templatestyles
self.base_templatestyles = cfg.templatestyles
self.templatestyles = args.templatestyles
end
 
function MessageBox:setMainspaceCategories()
local args = self.args
local cfg = self.cfg
 
if not cfg.allowMainspaceCategories then
return nil
end
 
local nums = {}
for _, prefix in ipairs{'cat', 'category', 'all'} do
args[prefix .. '1'] = args[prefix]
nums = union(nums, getArgNums(args, prefix))
end
 
-- The following is roughly equivalent to the old {{Ambox/category}}.
local date = args.date
date = type(date) == 'string' and date
local preposition = 'from'
for _, num in ipairs(nums) do
local mainCat = args['cat' .. tostring(num)]
or args['category' .. tostring(num)]
local allCat = args['all' .. tostring(num)]
mainCat = type(mainCat) == 'string' and mainCat
allCat = type(allCat) == 'string' and allCat
if mainCat and date and date ~= '' then
local catTitle = string.format('%s %s %s', mainCat, preposition, date)
self:addCat(0, catTitle)
catTitle = getTitleObject('Category:' .. catTitle)
if not catTitle or not catTitle.exists then
self:addCat(0, 'Articles with invalid date parameter in template')
end
elseif mainCat and (not date or date == '') then
self:addCat(0, mainCat)
end
if allCat then
self:addCat(0, allCat)
end
end
end
 
function MessageBox:setTemplateCategories()
local args = self.args
local cfg = self.cfg
 
-- Add template categories.
if cfg.templateCategory then
if cfg.templateCategoryRequireName then
if self.isTemplatePage then
self:addCat(10, cfg.templateCategory)
end
elseif not self.title.isSubpage then
self:addCat(10, cfg.templateCategory)
end
end
 
-- Add template error categories.
if cfg.templateErrorCategory then
local templateErrorCategory = cfg.templateErrorCategory
local templateCat, templateSort
if not self.name and not self.title.isSubpage then
templateCat = templateErrorCategory
elseif self.isTemplatePage then
local paramsToCheck = cfg.templateErrorParamsToCheck or {}
local count = 0
for i, param in ipairs(paramsToCheck) do
if not args[param] then
count = count + 1
end
end
if count > 0 then
templateCat = templateErrorCategory
templateSort = tostring(count)
end
if self.categoryNums and #self.categoryNums > 0 then
templateCat = templateErrorCategory
templateSort = 'C'
end
end
self:addCat(10, templateCat, templateSort)
end
end
 
function MessageBox:setAllNamespaceCategories()
-- Set categories for all namespaces.
if self.invalidTypeError then
local allSort = (self.title.namespace == 0 and 'Main:' or '') .. self.title.prefixedText
self:addCat('all', 'Wikipedia message box parameter needs fixing', allSort)
end
if self.isSubstituted then
self:addCat('all', 'Pages with incorrectly substituted templates')
end
end
 
function MessageBox:setCategories()
if self.title.namespace == 0 then
self:setMainspaceCategories()
elseif self.title.namespace == 10 then
self:setTemplateCategories()
end
self:setAllNamespaceCategories()
end
 
function MessageBox:renderCategories()
if not self.hasCategories then
-- No categories added, no need to pass them to Category handler so,
-- if it was invoked, it would return the empty string.
-- So we shortcut and return the empty string.
return ""
end
-- Convert category tables to strings and pass them through
-- [[Module:Category handler]].
return require('Module:Category handler')._main{
main = table.concat(self.categories[0] or {}),
template = table.concat(self.categories[10] or {}),
all = table.concat(self.categories.all or {}),
nocat = self.args.nocat,
page = self.args.page
}
end
 
function MessageBox:exportDiv()
local root = mw.html.create()
 
-- Add the subst check error.
if self.isSubstituted and self.name then
root:tag('b')
:addClass('error')
:wikitext(string.format(
'Template <code>%s[[Template:%s|%s]]%s</code> has been incorrectly substituted.',
mw.text.nowiki('{{'), self.name, self.name, mw.text.nowiki('}}')
))
end
 
local frame = mw.getCurrentFrame()
root:wikitext(frame:extensionTag{
name = 'templatestyles',
args = { src = self.base_templatestyles },
})
-- Add support for a single custom templatestyles sheet. Undocumented as
-- need should be limited and many templates using mbox are substed; we
-- don't want to spread templatestyles sheets around to arbitrary places
if self.templatestyles then
root:wikitext(frame:extensionTag{
name = 'templatestyles',
args = { src = self.templatestyles },
})
end
 
-- Create the box.
local mbox = root:tag('div')
mbox:attr('id', self.id or nil)
for i, class in ipairs(self.classes or {}) do
mbox:addClass(class or nil)
end
mbox
:cssText(self.style or nil)
 
if self.attrs then
mbox:attr(self.attrs)
end
local flex_container
if self.below then
-- we need to wrap the flex components (`image(right)` and `text`) in their
-- own container div to support the `below` parameter
flex_container = mw.html.create('div')
flex_container:addClass('mbox-flex')
else
-- the mbox itself is the parent, so we need no HTML flex_container
flex_container = mw.html.create()
end
 
-- Add the left-hand image.
if self.imageLeft then
local imageLeftCell = flex_container:tag('div'):addClass('mbox-image')
imageLeftCell
:addClass(self.imageLeftClass)
:wikitext(self.imageLeft or nil)
end
 
-- Add the text.
local textCell = flex_container:tag('div'):addClass('mbox-text')
if self.useCollapsibleTextFields then
-- The message box uses advanced text parameters that allow things to be
-- collapsible. At the moment, only ambox uses this.
textCell:cssText(self.textstyle or nil)
local textCellDiv = textCell:tag('div')
textCellDiv
:addClass('mbox-text-span')
:wikitext(self.issue or nil)
if (self.talk or self.fix) then
textCellDiv:tag('span')
:addClass('hide-when-compact')
:wikitext(self.talk and (' ' .. self.talk) or nil)
:wikitext(self.fix and (' ' .. self.fix) or nil)
end
textCellDiv:wikitext(self.date and (' ' .. self.date) or nil)
if self.info and not self.isSmall then
textCellDiv
:tag('span')
:addClass('hide-when-compact')
:wikitext(self.info and (' ' .. self.info) or nil)
end
if self.removalNotice then
textCellDiv:tag('span')
:addClass('hide-when-compact')
:tag('i')
:wikitext(string.format(" (%s)", self.removalNotice))
end
else
-- Default text formatting - anything goes.
textCell
:cssText(self.textstyle or nil)
:wikitext(self.text or nil)
end
 
-- Add the right-hand image.
if self.imageRight then
local imageRightCell = flex_container:tag('div'):addClass('mbox-imageright')
imageRightCell
:addClass(self.imageRightClass)
:wikitext(self.imageRight or nil)
end
mbox:node(flex_container)
 
-- Add the below row.
if self.below then
mbox:tag('div')
:addClass('mbox-text mbox-below')
:cssText(self.textstyle or nil)
:wikitext(self.below or nil)
end
 
-- Add error message for invalid type parameters.
if self.invalidTypeError then
root:tag('div')
:addClass('mbox-invalid-type')
:wikitext(string.format(
'This message box is using an invalid "type=%s" parameter and needs fixing.',
self.type or ''
))
end
 
-- Add categories.
root:wikitext(self:renderCategories() or nil)
 
return tostring(root)
end
 
function MessageBox:export()
 
local root = mw.html.create()
 
-- Add the subst check error.
if self.isSubstituted and self.name then
root:tag('b')
:addClass('error')
:wikitext(string.format(
'Template <code>%s[[Template:%s|%s]]%s</code> has been incorrectly substituted.',
mw.text.nowiki('{{'), self.name, self.name, mw.text.nowiki('}}')
))
end
 
local frame = mw.getCurrentFrame()
root:wikitext(frame:extensionTag{
name = 'templatestyles',
args = { src = self.base_templatestyles },
})
-- Add support for a single custom templatestyles sheet. Undocumented as
-- need should be limited and many templates using mbox are substed; we
-- don't want to spread templatestyles sheets around to arbitrary places
if self.templatestyles then
root:wikitext(frame:extensionTag{
name = 'templatestyles',
args = { src = self.templatestyles },
})
end
 
-- Create the box table.
local boxTable = root:tag('table')
boxTable:attr('id', self.id or nil)
for i, class in ipairs(self.classes or {}) do
boxTable:addClass(class or nil)
end
boxTable
:cssText(self.style or nil)
:attr('role', 'presentation')
 
if self.attrs then
boxTable:attr(self.attrs)
end
 
-- Add the left-hand image.
local row = boxTable:tag('tr')
if self.imageLeft then
local imageLeftCell = row:tag('td'):addClass('mbox-image')
if self.imageCellDiv then
-- If we are using a div, redefine imageLeftCell so that the image
-- is inside it. Divs use style="width: 52px;", which limits the
-- image width to 52px. If any images in a div are wider than that,
-- they may overlap with the text or cause other display problems.
imageLeftCell = imageLeftCell:tag('div'):addClass('mbox-image-div')
end
imageLeftCell
:addClass(self.imageLeftClass)
:wikitext(self.imageLeft or nil)
elseif self.imageEmptyCell then
-- Some message boxes define an empty cell if no image is specified, and
-- some don't. The old template code in templates where empty cells are
-- specified gives the following hint: "No image. Cell with some width
-- or padding necessary for text cell to have 100% width."
row:tag('td')
:addClass('mbox-empty-cell')
end
 
-- Add the text.
local textCell = row:tag('td'):addClass('mbox-text')
if self.useCollapsibleTextFields then
-- The message box uses advanced text parameters that allow things to be
-- collapsible. At the moment, only ambox uses this.
textCell:cssText(self.textstyle or nil)
local textCellDiv = textCell:tag('div')
textCellDiv
:addClass('mbox-text-span')
:wikitext(self.issue or nil)
if (self.talk or self.fix) then
textCellDiv:tag('span')
:addClass('hide-when-compact')
:wikitext(self.talk and (' ' .. self.talk) or nil)
:wikitext(self.fix and (' ' .. self.fix) or nil)
end
textCellDiv:wikitext(self.date and (' ' .. self.date) or nil)
if self.info and not self.isSmall then
textCellDiv
:tag('span')
:addClass('hide-when-compact')
:wikitext(self.info and (' ' .. self.info) or nil)
end
if self.removalNotice then
textCellDiv:tag('span')
:addClass('hide-when-compact')
:tag('i')
:wikitext(string.format(" (%s)", self.removalNotice))
end
else
-- Default text formatting - anything goes.
textCell
:cssText(self.textstyle or nil)
:wikitext(self.text or nil)
end
 
-- Add the right-hand image.
if self.imageRight then
local imageRightCell = row:tag('td'):addClass('mbox-imageright')
if self.imageCellDiv then
-- If we are using a div, redefine imageRightCell so that the image
-- is inside it.
imageRightCell = imageRightCell:tag('div'):addClass('mbox-image-div')
end
imageRightCell
:addClass(self.imageRightClass)
:wikitext(self.imageRight or nil)
end
 
-- Add the below row.
if self.below then
boxTable:tag('tr')
:tag('td')
:attr('colspan', self.imageRight and '3' or '2')
:addClass('mbox-text')
:cssText(self.textstyle or nil)
:wikitext(self.below or nil)
end
 
-- Add error message for invalid type parameters.
if self.invalidTypeError then
root:tag('div')
:addClass('mbox-invalid-type')
:wikitext(string.format(
'This message box is using an invalid "type=%s" parameter and needs fixing.',
self.type or ''
))
end
 
-- Add categories.
root:wikitext(self:renderCategories() or nil)
 
return tostring(root)
end
 
--------------------------------------------------------------------------------
-- Exports
--------------------------------------------------------------------------------
 
local p, mt = {}, {}
 
function p._exportClasses()
-- For testing.
return {
MessageBox = MessageBox
}
end
 
function p.main(boxType, args, cfgTables)
local box = MessageBox.new(boxType, args, cfgTables or mw.loadData(CONFIG_MODULE))
box:setParameters()
box:setCategories()
-- DIV MIGRATION CONDITIONAL
if box.cfg.div_structure then
return box:exportDiv()
end
-- END DIV MIGRATION CONDITIONAL
return box:export()
end
 
function mt.__index(t, k)
return function (frame)
if not getArgs then
getArgs = require('Module:Arguments').getArgs
end
return t.main(k, getArgs(frame, {trim = false, removeBlanks = false}))
end
end
 
return setmetatable(p, mt)

Revision as of 18:08, 18 December 2025

Template:Oldtfdfull Template:Permprot Template:Archives User:MiszaBot/config

CSS instead of tables

User:ClueBot III/DoNotArchiveUntil Template:Moved discussion from Could this thing use <div style="display:table;"> and <div style="display:table-cell;"> instead of literal tables and table cells (<table>, <td>)?

Were the any previous attempts to remake this using <div>? If so, what was the consensus? Sapphaline (talk) 09:46, 20 August 2025 (UTC)

A long time ago this would have been converted to divs but apparently IE sucked (this should not be news).
Today, I have User:Izno/Sandbox/Ambox with what are some skimmings and started a sandbox at Module:Message box/div. I have just done a very bad job of finishing this work. Izno (talk) 22:09, 24 August 2025 (UTC)
Which might be closer to done than not, honestly. I think what it currently needs is to
  1. Double check the ambox work
  2. Add "soft" support for the other kinds of boxes (where soft is defined as module-supports but config disabled)
  3. Merge tested /div version but not CSS into main
  4. Enable boxes of each kind one by one.
  5. Fix bugs that are identified
  6. Move CSS over to better-named stylesheet
  7. Delete the /div CSS (I won't be too sad)
  8. Remove main support for table versions, possibly rename some things
Izno (talk) 22:42, 24 August 2025 (UTC)
I have now put this plan in a publicly editable place at Module:Message box/div/doc. IznoPublic (talk) 00:26, 26 August 2025 (UTC)
Hi! I didn't know you were doing this, so I made something similar. It seems to work:
Iniquity (talk) 16:57, 11 September 2025 (UTC)
Yes, I did it in its own sandbox because it's a longterm enough project not to be done in the main sandbox, which should generally be releasable ad hoc for trivial issues. Izno (talk) 17:03, 11 September 2025 (UTC)
And also, there are enough other dependencies that "just change the two or three places" isn't going to fly. Izno (talk) 17:06, 11 September 2025 (UTC)
Where else do you think this will affect? ​​It seems that only the mobile version is oriented towards table.ambox, which can also be corrected by CSS Iniquity (talk) 17:09, 11 September 2025 (UTC)
I have already documented in Module:Message box/div/doc multiple places that will need careful work, ambox among them. Please feel free to peruse and ask questions about what's there and why. Izno (talk) 17:41, 11 September 2025 (UTC)
Thanks! Iniquity (talk) 17:47, 11 September 2025 (UTC)
What's broken here? I've probably wrong but AFAIK for accessibility the existing role="presentation" should suffice. Aaron Liu (talk) 23:21, 28 August 2025 (UTC)
You should always endeavor to use the default aria role element. In this case, that's not a table. Ignoring that, tables are shit for doing other presentation with. Izno (talk) 03:20, 29 August 2025 (UTC)
This /div work is great work, thanks for this waddie96 ★ (talk) 19:49, 8 September 2025 (UTC)
Ok, I think we can do {{cmbox}} now. Based on what I wrote down before, the process of a rollout is:
  1. Alert some key pages. Has to include some verbiage like

    A change is occurring to how {{cmbox}} is implemented to support mobile resolutions better. It may cause some temporary display weirdness. Further information is available at Module talk:Message box#cmbox migration.

    with some text at the specific section

    A change is planned to occur in how {{cmbox}} is implemented. It should help improve display at mobile resolutions now, and accessibility later. cmbox was chosen because it has lower reader-facing impact than most other message box types and it's fairly self-contained. The change to cmbox will likely pave the way for other message boxes ({{fmbox}} is probably next).

    You can expect some difference in styling from previous for a small period due to the job queue, after which it should return to "normal". You should be able to correct it manually if you want with one of the usual steps (purge, null edit, or dummy edit). If an issue with display persists, leave a comment here (this scenario may be possible with some unexpected setup cmboxes).

  2. Sync Module:Message box/sandbox to Module:Message box (first time only)
  3. Within quick succession to next step, sync Module:Message box/configuration/sandbox to Module:Message box/configuration
  4. Within quick succession to previous step, sync Module:Message box/div/cmbox.css to Module:Message box/cmbox.css
Izno (talk) 17:08, 1 October 2025 (UTC)
The /div main and config modules have got some other adjustments that now make it different from what will end up going live, so they shouldn't generally be synced directly. For future me. Izno (talk) 21:59, 1 October 2025 (UTC)
Also messages now posted to VPT and Common.css. Izno (talk) 22:00, 1 October 2025 (UTC)
cmbox is deployed. Izno (talk) 20:30, 2 October 2025 (UTC)
Ok, cmbox has been basically quiet besides notes from the below. I will now work on fmbox, which should also be relatively low impact. I'm also starting to sketch out imbox which may need to interact with template content from Commons as well as c:MediaWiki:Filepage.css. Izno (talk) 20:44, 7 October 2025 (UTC)
Turns out I don't currently have to worry about commons names, which is something I should have noted when I split message box CSS during the TemplateStylization. Izno (talk) 01:03, 17 October 2025 (UTC)
What does Template:Tq mean exactly?
Also, what can I help with. waddie96 ★ (talk) 03:56, 17 October 2025 (UTC)
All of the CSS for the message boxes was once in MediaWiki:Common.css. I moved it to TemplateStyles with some effort because of reasons.
This effort now that I've got my feet under me probably doesn't need much assistance. If you want to spend time on something, working on the problems listed at MediaWiki talk:Common.css/to do#Infobox would be excellent. If you want to spend some time on stuff, crafting an infobox (using Lua or template) to fix our career statistics pages would be super helpful. Izno (talk) 00:27, 19 October 2025 (UTC)
Template:Ping any progress? sapphaline (talk) 13:20, 18 December 2025 (UTC)
You can see the progress at Module:Message box/div/doc. Izno (talk) 18:08, 18 December 2025 (UTC)

imbox migration

A change is occurring in how {{imbox}} is implemented. It should help improve display at mobile resolutions now, and accessibility later. imbox was chosen third because it has lower reader-facing impact than most other message box types and it's fairly self-contained. (There is some other planning information in #CSS instead of tables.) (Previously, cmbox and fmbox were done.)

You can expect some difference in styling from previous for a small period due to the job queue, after which it should return to "normal". You should be able to correct it manually if you want with one of the usual steps (purge, null edit, or dummy edit). If an issue with display persists, leave a comment here (this scenario may be possible with some unexpected setup imboxes). This may also, but should not have, affected the already-migrated cmbox and fmbox, so if those also appear to have an issue, here is a good spot now. Izno (talk) 18:34, 19 October 2025 (UTC)

T367463

Since it's fixed, can the relevant CSS rule be removed? Andyrom75 (talk) 07:07, 19 November 2025 (UTC)

@Izno, @Jdlrobson, ping. Andyrom75 (talk) 07:08, 19 November 2025 (UTC)
What do you think is fixed exactly? Izno (talk) 07:14, 19 November 2025 (UTC)
And what rule do you think should be removed? Izno (talk) 07:19, 19 November 2025 (UTC)

Plural for {{Hooks}}

Template:Edit fully-protected


Please copy this sandbox version (not the current version, which links to Module:Message box/configuration/sandbox) to live.

Changes.

Let me know when done, and I'll update the documentation for the module, and make other tweaks.

All the best: Rich Farmbrough 17:12, 16 December 2025 (UTC).

File:X mark.svg Not done for now: please establish a consensus for this alteration before creating an edit request. Namely, making a change to a template used on 20 million pages because you created a template today? For a wording tweak? Please show a consensus that this is something desirable. Izno (talk) 18:09, 16 December 2025 (UTC)
Looking at the archive I see you make changes without awaiting consensus. I find this modern gatekeeping behaviour unfortunate. All the best: Rich Farmbrough 02:48, 17 December 2025 (UTC).
Flinging some incorrect mud (I have been very public about the changes I've implemented of my own resort in this module even if you didn't find where) is not any more likely to convince me or anyone else of the value of Template:Em change (see also WP:OTHERSTUFF: your edit request is relevant, not any of my edits).
I also note that you were apparently able to implement the same display as what you wanted without making the change in this module. Izno (talk) 04:00, 17 December 2025 (UTC)
And just to be very clear, the two changes at my desire have been the following:
  1. Supporting TemplateStyles. In this module, that had prior requests at Use TemplateStyles, A question to small param and TemplateStyle, and Site-local configuration.... I had set up MediaWiki talk:Common.css/to do previously with provided description there, and have generally advertised that link every chance I get because I don't like being the only person spending time on making changes more accessible to a wider public (you may check what links here at your leisure), and had also generally mused about the problem Template:Em earlier at In the context of meta templates. That culminated, when I finally got around to it, in mbox is now TemplateStyled only and associated target link. For which there have been no complaints not trivially remedied.
  2. Changing the table structure to divs. Template:Em change is right there and was also implicated in Aria roles and separately reinforced in the individual advertisements I've so far made, like cmbox migration. The cmbox migration section was incidentally also advertised to VPT.
Any other changes that I made were implemented due to requested edit. Izno (talk) 04:21, 17 December 2025 (UTC)
I don't mind that you made intelligent changes to the module, saying "Ok I did it anyway" - in fact I absolutely support them. Even if I would have disagreed with them.
And yes, I coded around the obstacle by using an older method which I had previously used in {{Hook}} (which I created). People have "updated" that, I do them the courtesy of assuming that their updates add value, unless I know otherwise.
If someone wants to update {{Hooks}} in the same way that {{Hook}} was updated, they will have to, apparently, gain consensus. I won't.
If I see a problem on Wikipedia I like to fix it. If something stops me doing it one way, I'll usually try another.
Hope that is all clear, and that you agree with my sentiments.
All the best: Rich Farmbrough 13:47, 17 December 2025 (UTC).